]> err.no Git - linux-2.6/commitdiff
pkt_sched: Fix actions referencing
authorJamal Hadi Salim <hadi@cyberus.ca>
Fri, 8 Aug 2008 03:37:22 +0000 (20:37 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Aug 2008 03:37:22 +0000 (20:37 -0700)
When an action is added several times with the same exact index
it gets deleted on every even-numbered attempt.
This fixes that issue.

Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/act_api.c

index d308c19aa3f9be6d6087aecfa27dcc55dead6eed..26c7e1f9a35002d3bf2dd9f825d9a54041bb96a5 100644 (file)
@@ -205,10 +205,9 @@ struct tcf_common *tcf_hash_check(u32 index, struct tc_action *a, int bind,
 {
        struct tcf_common *p = NULL;
        if (index && (p = tcf_hash_lookup(index, hinfo)) != NULL) {
-               if (bind) {
+               if (bind)
                        p->tcfc_bindcnt++;
-                       p->tcfc_refcnt++;
-               }
+               p->tcfc_refcnt++;
                a->priv = p;
        }
        return p;