]> err.no Git - linux-2.6/commitdiff
r8169: fix infinite loop during hotplug
authorArnaud Patard <apatard@mandriva.com>
Thu, 12 Oct 2006 20:33:31 +0000 (22:33 +0200)
committerFrancois Romieu <romieu@electric-eye.fr.zoreil.com>
Thu, 12 Oct 2006 20:10:44 +0000 (22:10 +0200)
Bug reported for PCMCIA.

Signed-off-by: Arnaud Patard <apatard@mandriva.com>
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
drivers/net/r8169.c

index c7309e98f89d18b1d5d7bc6705df0a62e299c721..c2c9a86e445cb15ee851057f72cb3cbbd8a08da7 100644 (file)
@@ -2702,6 +2702,7 @@ static void rtl8169_down(struct net_device *dev)
        struct rtl8169_private *tp = netdev_priv(dev);
        void __iomem *ioaddr = tp->mmio_addr;
        unsigned int poll_locked = 0;
+       unsigned int intrmask;
 
        rtl8169_delete_timer(dev);
 
@@ -2740,8 +2741,11 @@ core_down:
         * 2) dev->change_mtu
         *    -> rtl8169_poll can not be issued again and re-enable the
         *       interruptions. Let's simply issue the IRQ down sequence again.
+        *
+        * No loop if hotpluged or major error (0xffff).
         */
-       if (RTL_R16(IntrMask))
+       intrmask = RTL_R16(IntrMask);
+       if (intrmask && (intrmask != 0xffff))
                goto core_down;
 
        rtl8169_tx_clear(tp);