]> err.no Git - linux-2.6/commitdiff
net/phy: Fix 88e1111 copper/fiber selection in RGMII mode
authorWang Jian <lark@linux.net.cn>
Wed, 16 Jul 2008 13:46:20 +0000 (21:46 +0800)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 22 Jul 2008 21:59:12 +0000 (17:59 -0400)
MII_M1111_HWCFG_FIBER_COPPER_RES is a bit of MII_M1111_PHY_EXT_SR, not
MII_M1111_PHY_EXT_CR.

Signed-off-by: Wang Jian <lark@linux.net.cn>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/phy/marvell.c

index 737512c00971dbe722252405c95a9eec51d2576b..4aa54794704045dfdec94bbaafea2d88970e163a 100644 (file)
@@ -158,7 +158,6 @@ static int m88e1111_config_init(struct phy_device *phydev)
 {
        int err;
        int temp;
-       int mode;
 
        /* Enable Fiber/Copper auto selection */
        temp = phy_read(phydev, MII_M1111_PHY_EXT_SR);
@@ -198,9 +197,7 @@ static int m88e1111_config_init(struct phy_device *phydev)
 
                temp &= ~(MII_M1111_HWCFG_MODE_MASK);
 
-               mode = phy_read(phydev, MII_M1111_PHY_EXT_CR);
-
-               if (mode & MII_M1111_HWCFG_FIBER_COPPER_RES)
+               if (temp & MII_M1111_HWCFG_FIBER_COPPER_RES)
                        temp |= MII_M1111_HWCFG_MODE_FIBER_RGMII;
                else
                        temp |= MII_M1111_HWCFG_MODE_COPPER_RGMII;