]> err.no Git - libchamplain/commitdiff
Don't invoke gperl_callback_invoke() with the extra data gpointer.
authorEmmanuel Rodriguez <emmanuel.rodriguez@gmail.com>
Tue, 19 May 2009 10:08:15 +0000 (12:08 +0200)
committerPierre-Luc Beaudoin <pierre-luc@pierlux.com>
Fri, 12 Jun 2009 03:20:45 +0000 (23:20 -0400)
The data gpointer is used to pass the Perl callback. It makes no sense to pass
it back to the Perl callback.

bindings/perl/Champlain/xs/ChamplainMapSourceFactory.xs

index 50dffdafcf49d2d9bbe8b502b2b8da27a3a95680..3cc403e4921dbcf7b77ffd7345e9287f080258d0 100644 (file)
@@ -19,8 +19,8 @@ champlainperl_constructor (ChamplainMapSourceDesc *desc, gpointer data) {
        }
        
        g_value_init(&return_value, callback->return_type);
-       
-       gperl_callback_invoke(callback, &return_value, desc, data);
+       /* FIXME desc is not passed as a Champlain::MapSourceDesc to the perl callback */
+       gperl_callback_invoke(callback, &return_value, desc);
        
        retval = g_value_get_object (&return_value);
        g_value_unset(&return_value);