]> err.no Git - linux-2.6/commitdiff
[SPARC64]: Fix bug in unaligned load endianness swapping
authorDavid S. Miller <davem@sunset.davemloft.net>
Wed, 28 Sep 2005 23:48:40 +0000 (16:48 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 28 Sep 2005 23:48:40 +0000 (16:48 -0700)
The in-memory value was being swapped, not the value we
loaded into the register.

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc64/kernel/unaligned.c

index 42718f6a7d3671ea349c3918f2355c11809c272c..02af08ffec8ffd54b57ebab9006ecc0876950718 100644 (file)
@@ -294,7 +294,7 @@ asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn, u
 
                kernel_mna_trap_fault();
        } else {
-               unsigned long addr;
+               unsigned long addr, *reg_addr;
                int orig_asi, asi;
 
                addr = compute_effective_address(regs, insn,
@@ -319,11 +319,11 @@ asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn, u
                };
                switch (dir) {
                case load:
-                       do_int_load(fetch_reg_addr(((insn>>25)&0x1f), regs),
-                                   size, (unsigned long *) addr,
+                       reg_addr = fetch_reg_addr(((insn>>25)&0x1f), regs);
+                       do_int_load(reg_addr, size, (unsigned long *) addr,
                                    decode_signedness(insn), asi);
                        if (unlikely(asi != orig_asi)) {
-                               unsigned long val_in = *(unsigned long *) addr;
+                               unsigned long val_in = *reg_addr;
                                switch (size) {
                                case 2:
                                        val_in = swab16(val_in);
@@ -339,7 +339,7 @@ asmlinkage void kernel_unaligned_trap(struct pt_regs *regs, unsigned int insn, u
                                        BUG();
                                        break;
                                };
-                               *(unsigned long *) addr = val_in;
+                               *reg_addr = val_in;
                        }
                        break;