]> err.no Git - linux-2.6/commitdiff
firewire: fw-sbp2: remove unnecessary memset
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 28 Feb 2008 19:52:43 +0000 (20:52 +0100)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 18 Apr 2008 15:55:32 +0000 (17:55 +0200)
orb came from kzalloc.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/fw-sbp2.c

index d1bdf1807c4f482a9ab39b440d82089a20acae4b..71146ba01e63b3fe110d8feca6ce9916ff64927a 100644 (file)
@@ -1454,7 +1454,6 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done)
        orb->cmd  = cmd;
 
        orb->request.next.high   = cpu_to_be32(SBP2_ORB_NULL);
-       orb->request.next.low    = 0x0;
        /*
         * At speed 100 we can do 512 bytes per packet, at speed 200,
         * 1024 bytes per packet etc.  The SBP-2 max_payload field
@@ -1474,8 +1473,6 @@ static int sbp2_scsi_queuecommand(struct scsi_cmnd *cmd, scsi_done_fn_t done)
        if (scsi_sg_count(cmd) && sbp2_map_scatterlist(orb, device, lu) < 0)
                goto out;
 
-       memset(orb->request.command_block,
-              0, sizeof(orb->request.command_block));
        memcpy(orb->request.command_block, cmd->cmnd, COMMAND_SIZE(*cmd->cmnd));
 
        orb->base.callback = complete_command_orb;