Fix sh_keysc double free

Avoid double free situation from happening by removing input_free_device()
after input_unregister_device(). Suggested by Dmitry Torokhov.

Signed-off-by: Magnus Damm <damm@igel.co.jp>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>

diff --git a/drivers/input/keyboard/sh_keysc.c b/drivers/input/keyboard/sh_keysc.c
index 5d0864a9e94bbe84d696297428ff2d0cc3bdd231..8486abc457edd02c982cde57319388711cddc694 100644 (file)
--- a/drivers/input/keyboard/sh_keysc.c
+++ b/drivers/input/keyboard/sh_keysc.c
@@ -238,7 +238,6 @@ static int __devexit sh_keysc_remove(struct platform_device *pdev)
 
        input_unregister_device(priv->input);
        free_irq(platform_get_irq(pdev, 0), pdev);
-       input_free_device(priv->input);
        iounmap(priv->iomem_base);
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);