]> err.no Git - linux-2.6/commitdiff
i2c/tps65010: Add missing intialization of client data
authorJean Delvare <khali@linux-fr.org>
Tue, 29 Apr 2008 21:11:38 +0000 (23:11 +0200)
committerJean Delvare <khali@hyperion.delvare>
Tue, 29 Apr 2008 21:11:38 +0000 (23:11 +0200)
tps65010_remove() calls i2c_get_clientdata(client) but the client data
is never set during initialization, so it gets a NULL pointer at best.

I guess it was never spotted because the tps65010 driver is typically
not built modular so this function is discarded.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>
drivers/i2c/chips/tps65010.c

index b67f69c2e7f3850c9a80cf405dc78a3b29505d93..feabd12c081c48ba8bf4423bbe4b01ae42ccc986 100644 (file)
@@ -527,6 +527,7 @@ static int __exit tps65010_remove(struct i2c_client *client)
        flush_scheduled_work();
        debugfs_remove(tps->file);
        kfree(tps);
+       i2c_set_clientdata(client, NULL);
        the_tps = NULL;
        return 0;
 }
@@ -615,6 +616,7 @@ static int tps65010_probe(struct i2c_client *client)
                i2c_smbus_read_byte_data(client, TPS_DEFGPIO),
                i2c_smbus_read_byte_data(client, TPS_MASK3));
 
+       i2c_set_clientdata(client, tps);
        the_tps = tps;
 
 #if    defined(CONFIG_USB_GADGET) && !defined(CONFIG_USB_OTG)