]> err.no Git - linux-2.6/commitdiff
[PATCH] bonding: fix ->get_settings error checking
authorEric Sesterhenn <snakebyte@gmx.de>
Fri, 20 Jan 2006 20:30:01 +0000 (23:30 +0300)
committerJeff Garzik <jgarzik@pobox.com>
Fri, 27 Jan 2006 03:08:56 +0000 (22:08 -0500)
Since get_settings() returns a signed int and it gets checked
for < 0 to catch an error, res should be a signed int too.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/bonding/bond_main.c

index 2582d98ef5c3308c16214b75f520ec1abb1b97e4..4ff006c37626b92c8e80085480fc01f090da1cdb 100644 (file)
@@ -576,7 +576,7 @@ static int bond_update_speed_duplex(struct slave *slave)
        slave->duplex = DUPLEX_FULL;
 
        if (slave_dev->ethtool_ops) {
-               u32 res;
+               int res;
 
                if (!slave_dev->ethtool_ops->get_settings) {
                        return -1;