]> err.no Git - linux-2.6/commitdiff
Input: fm801-gp - fix use after free
authorDmitry Torokhov <dtor@insightbb.com>
Fri, 7 Jul 2006 03:54:30 +0000 (23:54 -0400)
committerDmitry Torokhov <dtor@insightbb.com>
Fri, 7 Jul 2006 03:54:30 +0000 (23:54 -0400)
Fixes Coverity #id 916

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
drivers/input/gameport/fm801-gp.c

index 47e93daa0fa7c498aec5ae237135126d0ef2e040..90de5afe03c21a40c95383d01f919e2b15699eb8 100644 (file)
@@ -106,10 +106,10 @@ static int __devinit fm801_gp_probe(struct pci_dev *pci, const struct pci_device
        gp->gameport = port;
        gp->res_port = request_region(port->io, 0x10, "FM801 GP");
        if (!gp->res_port) {
-               kfree(gp);
-               gameport_free_port(port);
                printk(KERN_DEBUG "fm801-gp: unable to grab region 0x%x-0x%x\n",
                        port->io, port->io + 0x0f);
+               gameport_free_port(port);
+               kfree(gp);
                return -EBUSY;
        }