]> err.no Git - linux-2.6/commitdiff
[NETFILTER]: ctnetlink: remove bogus checks in ICMP protocol at dumping
authorPablo Neira Ayuso <pablo@netfilter.org>
Thu, 5 Jan 2006 20:16:41 +0000 (12:16 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 5 Jan 2006 20:16:41 +0000 (12:16 -0800)
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/ip_conntrack_proto_icmp.c

index 5f9925db608ef3ab4255f266d0550aec421fc580..19cc55055584fa3d6b964bfc646dd7bf09d876b0 100644 (file)
@@ -279,10 +279,6 @@ static int icmp_tuple_to_nfattr(struct sk_buff *skb,
        NFA_PUT(skb, CTA_PROTO_ICMP_CODE, sizeof(u_int8_t),
                &t->dst.u.icmp.code);
 
-       if (t->dst.u.icmp.type >= sizeof(valid_new) 
-           || !valid_new[t->dst.u.icmp.type])
-               return -EINVAL;
-
        return 0;
 
 nfattr_failure: