]> err.no Git - linux-2.6/commitdiff
[ALSA] es1968 - fix coding style in the last patch
authorAndrew Morton <akpm@linux-foundation.org>
Mon, 14 Apr 2008 11:09:33 +0000 (13:09 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 24 Apr 2008 10:00:33 +0000 (12:00 +0200)
WARNING: braces {} are not necessary for single statement blocks
#40: FILE: sound/pci/es1968.c:1831:
+       if (diff > 1) {
+               __maestro_write(chip, IDR0_DATA_PORT, cp1);
+       }

total: 0 errors, 1 warnings, 35 lines checked

./patches/es1968-fix-jitter-on-some-maestro-cards.patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andreas Mueller <andreas@stapelspeicher.org>
Tested-by: Rene Herman <rene.herman@keyaccess.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/es1968.c

index f8f3bb662d1726ac0b7c516d630bc55a3f1536f2..13837989606136af7e52cbe79d18c40e86f64e30 100644 (file)
@@ -1840,9 +1840,8 @@ static void snd_es1968_suppress_jitter(struct es1968 *chip, struct esschan *es)
        cp2 = __apu_get_register(chip, 1, 5);
        diff = (cp1 > cp2 ? cp1 - cp2 : cp2 - cp1);
 
-       if (diff > 1) {
+       if (diff > 1)
                __maestro_write(chip, IDR0_DATA_PORT, cp1);
-       }
 }
 
 /*