]> err.no Git - linux-2.6/commitdiff
ARM: OMAP: DMA: Don't mark channel active in omap_enable_channel_irq
authorJarkko Nikula <jarkko.nikula@nokia.com>
Tue, 13 May 2008 10:26:03 +0000 (13:26 +0300)
committerTony Lindgren <tony@atomide.com>
Thu, 5 Jun 2008 21:30:15 +0000 (14:30 -0700)
Channel should be marked active only when DMA is really started. Otherwise
just omap_request_dma, omap_dma_link_lch and omap_dma_unlink_lch will cause
incorrect dump_stack().

Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/plat-omap/dma.c

index c00eda588cd81b2ad87d51646a27b7ffcd577549..39c637b0ffeacdceba864caf3a23c1e7f0eeb3b4 100644 (file)
@@ -501,8 +501,6 @@ static inline void omap_enable_channel_irq(int lch)
 
        /* Enable some nice interrupts. */
        OMAP_DMA_CICR_REG(lch) = dma_chan[lch].enabled_irqs;
-
-       dma_chan[lch].flags |= OMAP_DMA_ACTIVE;
 }
 
 static void omap_disable_channel_irq(int lch)