]> err.no Git - linux-2.6/commitdiff
[NETDRV]: Perform missing csum_offset conversions
authorHerbert Xu <herbert@gondor.apana.org.au>
Tue, 24 Apr 2007 00:06:40 +0000 (17:06 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Thu, 26 Apr 2007 05:28:41 +0000 (22:28 -0700)
When csum_offset was introduced we did a conversion from csum to
csum_offset where applicable.  A couple of drivers were missed in
this process.

It was harmless to begin with since the two fields coincided.  Now
that we've made them different with the addition of csum_start, the
missed drivers must be converted or they can't send packets out at
all that require checksum offload.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/atl1/atl1_main.c
drivers/net/e1000/e1000_main.c

index d60c2217332cad3e0f25828811b8e86c1b894835..4b1d4d153ecfe909e64eca72d90be43d69be0440 100644 (file)
@@ -1328,7 +1328,7 @@ static int atl1_tx_csum(struct atl1_adapter *adapter, struct sk_buff *skb,
 
        if (likely(skb->ip_summed == CHECKSUM_PARTIAL)) {
                cso = skb_transport_offset(skb);
-               css = cso + skb->csum;
+               css = cso + skb->csum_offset;
                if (unlikely(cso & 0x1)) {
                        printk(KERN_DEBUG "%s: payload offset != even number\n",
                                atl1_driver_name);
index 610216ec4918ea2bdf7ea64e7a3900030f920f54..48e2ade704d383d7c46c633798587b6d27a6427a 100644 (file)
@@ -2959,7 +2959,8 @@ e1000_tx_csum(struct e1000_adapter *adapter, struct e1000_tx_ring *tx_ring,
 
                context_desc->lower_setup.ip_config = 0;
                context_desc->upper_setup.tcp_fields.tucss = css;
-               context_desc->upper_setup.tcp_fields.tucso = css + skb->csum;
+               context_desc->upper_setup.tcp_fields.tucso =
+                       css + skb->csum_offset;
                context_desc->upper_setup.tcp_fields.tucse = 0;
                context_desc->tcp_seg_setup.data = 0;
                context_desc->cmd_and_length = cpu_to_le32(E1000_TXD_CMD_DEXT);