]> err.no Git - linux-2.6/commitdiff
[PATCH] libata: trivial updates to ata_sg_init_one()
authorTejun Heo <htejun@gmail.com>
Tue, 14 Nov 2006 13:35:43 +0000 (22:35 +0900)
committerJeff Garzik <jeff@garzik.org>
Sat, 2 Dec 2006 03:45:57 +0000 (22:45 -0500)
There's no need to memset &qc->sgent manually, sg_init_one() clears
sgent inside it.  Also, kill not-so-necessary sg local variable.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/ata/libata-core.c

index 21f8d61e5879faeed1af2aa4720082a413bb25b7..a52c0719883939ec45876cd0527738f16ea4632a 100644 (file)
@@ -3491,19 +3491,15 @@ void ata_noop_qc_prep(struct ata_queued_cmd *qc) { }
 
 void ata_sg_init_one(struct ata_queued_cmd *qc, void *buf, unsigned int buflen)
 {
-       struct scatterlist *sg;
-
        qc->flags |= ATA_QCFLAG_SINGLE;
 
-       memset(&qc->sgent, 0, sizeof(qc->sgent));
        qc->__sg = &qc->sgent;
        qc->n_elem = 1;
        qc->orig_n_elem = 1;
        qc->buf_virt = buf;
        qc->nbytes = buflen;
 
-       sg = qc->__sg;
-       sg_init_one(sg, buf, buflen);
+       sg_init_one(&qc->sgent, buf, buflen);
 }
 
 /**