V4L/DVB (7063): xc5000: Fix OOPS caused by missing firmware

xc5000: Fix OOPS caused by missing firmware.

Signed-off-by: Chaogui Zhang <czhang1974@gmail.com>
Acked-by: Steven Toth <stoth@hauppauge.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

diff --git a/drivers/media/dvb/frontends/xc5000.c b/drivers/media/dvb/frontends/xc5000.c
index a13027e09cdac59b50196bcca373b7faccf7fae5..f642ca200b596096c2f85167faeeeef4ec6b091f 100644 (file)
--- a/drivers/media/dvb/frontends/xc5000.c
+++ b/drivers/media/dvb/frontends/xc5000.c
@@ -558,6 +558,7 @@ static int xc5000_fwupload(struct dvb_frontend* fe)
        if (ret) {
                printk(KERN_ERR "xc5000: Upload failed. (file not found?)\n");
                ret = XC_RESULT_RESET_FAILURE;
+               goto out;
        } else {
                printk(KERN_INFO "xc5000: firmware read %Zu bytes.\n",
                       fw->size);
@@ -572,6 +573,7 @@ static int xc5000_fwupload(struct dvb_frontend* fe)
                ret = xc_load_i2c_sequence(fe,  fw->data );
        }
 
+out:
        release_firmware(fw);
        return ret;
 }