]> err.no Git - linux-2.6/commitdiff
V4L/DVB (3568j): adv7175: Drop unused encoder dump command
authorJean Delvare <khali@linux-fr.org>
Wed, 22 Mar 2006 06:48:34 +0000 (03:48 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Thu, 23 Mar 2006 14:24:28 +0000 (11:24 -0300)
Drop support for the ENCODER_DUMP command in the adv7175 driver.  ENCODER_DUMP
was never actually defined as far as I can see, so the code was ifdef'd out,
and I suspect it was never used, not even once, as it includes an obvious
array overrun.

The register values of this specific chip can be dumped in a generic way using
the i2c-dev driver and the "i2cdump" user-space tool if it is ever really
needed.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/adv7175.c

index 245f94265758d8e2d6907f44a3991c7f5d0085b8..ca86de0c280585066bf70fbf4f856f619fae07b8 100644 (file)
@@ -165,24 +165,6 @@ set_subcarrier_freq (struct i2c_client *client,
        adv7175_write(client, 0x05, 0x25);
 }
 
-#ifdef ENCODER_DUMP
-static void
-dump (struct i2c_client *client)
-{
-       struct adv7175 *encoder = i2c_get_clientdata(client);
-       int i, j;
-
-       printk(KERN_INFO "%s: registry dump\n", I2C_NAME(client));
-       for (i = 0; i < 182 / 8; i++) {
-               printk("%s: 0x%02x -", I2C_NAME(client), i * 8);
-               for (j = 0; j < 8; j++) {
-                       printk(" 0x%02x", encoder->reg[i * 8 + j]);
-               }
-               printk("\n");
-       }
-}
-#endif
-
 /* ----------------------------------------------------------------------- */
 // Output filter:  S-Video  Composite
 
@@ -401,14 +383,6 @@ adv7175_command (struct i2c_client *client,
        }
                break;
 
-#ifdef ENCODER_DUMP
-       case ENCODER_DUMP:
-       {
-               dump(client);
-       }
-               break;
-#endif
-
        default:
                return -EINVAL;
        }