]> err.no Git - linux-2.6/commitdiff
e1000e: Fix CRC stripping in hardware context bug
authorAuke Kok <auke-jan.h.kok@intel.com>
Tue, 12 Feb 2008 23:20:24 +0000 (15:20 -0800)
committerJeff Garzik <jeff@garzik.org>
Fri, 15 Feb 2008 15:52:01 +0000 (10:52 -0500)
CRC stripping was only correctly enabled for packet split recieves
which is used when receiving jumbo frames. Correctly enable SECRC
also for normal buffer packet receives.

Tested by Andy Gospodarek and Johan Andersson, see bugzilla #9940.

Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/e1000e/netdev.c

index b9b0d321e70b750a21e33f8e11bf7800a83d3fd7..ea4ecc3bf82e46aa3ea0638a0f02f898dc237188 100644 (file)
@@ -1690,6 +1690,9 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
        else
                rctl |= E1000_RCTL_LPE;
 
+       /* Enable hardware CRC frame stripping */
+       rctl |= E1000_RCTL_SECRC;
+
        /* Setup buffer sizes */
        rctl &= ~E1000_RCTL_SZ_4096;
        rctl |= E1000_RCTL_BSEX;
@@ -1755,9 +1758,6 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
 
                /* Enable Packet split descriptors */
                rctl |= E1000_RCTL_DTYP_PS;
-               
-               /* Enable hardware CRC frame stripping */
-               rctl |= E1000_RCTL_SECRC;
 
                psrctl |= adapter->rx_ps_bsize0 >>
                        E1000_PSRCTL_BSIZE0_SHIFT;