]> err.no Git - linux-2.6/commitdiff
saa7134: fix thread shutdown handling
authorJeff Mahoney <jeffm@suse.com>
Wed, 27 Jun 2007 21:09:58 +0000 (14:09 -0700)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 28 Jun 2007 18:34:54 +0000 (11:34 -0700)
This patch changes the test for the thread pid from >= 0 to > 0.

When the saa8134 driver initialization fails after a certain point, it goes
through the complete shutdown process for the driver.  Part of shutting it
down includes tearing down the thread for tv audio.

The test for tearing down the thread tests for >= 0.  Since the dev
structure is kzalloc'd, the test will always be true if we haven't tried to
start the thread yet.  We end up waiting on pid 0 to complete, which will
never happen, so we lock up.

This bug was observed in Novell Bugzilla 284718, when request_irq() failed.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/media/video/saa7134/saa7134-tvaudio.c

index 7b56041186dcbc0a96bab5656754d2a2d7ecd0d9..30395d6b5f14234a0a7cd12aeacd5365629e4ad5 100644 (file)
@@ -1005,7 +1005,7 @@ int saa7134_tvaudio_init2(struct saa7134_dev *dev)
 int saa7134_tvaudio_fini(struct saa7134_dev *dev)
 {
        /* shutdown tvaudio thread */
-       if (dev->thread.pid >= 0) {
+       if (dev->thread.pid > 0) {
                dev->thread.shutdown = 1;
                wake_up_interruptible(&dev->thread.wq);
                wait_for_completion(&dev->thread.exit);