minor code cleanups

git-svn-id: http://svn.opengroupware.org/SOPE/trunk@1217 e4a50df8-12e2-0310-a44c-efbce7f8a7e3

diff --git a/sope-appserver/NGObjWeb/ChangeLog b/sope-appserver/NGObjWeb/ChangeLog
index 0032ada79dddb63a538ccaf5659cc3541ebc69ac..f9acd47f8b90e4803837c0fa42fc34d7282d3b0f 100644 (file)
--- a/sope-appserver/NGObjWeb/ChangeLog
+++ b/sope-appserver/NGObjWeb/ChangeLog
@@ -1,3 +1,8 @@
+2006-02-22  Helge Hess  <helge.hess@opengroupware.org>
+
+       * WOComponent.m, WODirectAction.m, DynamicElements/WOBrowser.m: minor
+         code cleanups (v4.5.219)
+
 2006-01-25  Marcus Mueller  <znek@mulle-kybernetik.com>
 
        * SoObjects/SoObject+Traversal.m: stop traversal immediately if an

diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m b/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
index 0900cb8ca1d13c7c2fd51e9666bd74814dc5132c..9af481f828b2a77de18ac3cf53aa72ddaa483dcc 100644 (file)
--- a/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
+++ b/sope-appserver/NGObjWeb/DynamicElements/WOBrowser.m
@@ -62,8 +62,8 @@
 
 - (id)initWithName:(NSString *)_name
   associations:(NSDictionary *)_config
-  template:(WOElement *)_c {
-
+  template:(WOElement *)_c
+{
   if ((self = [super initWithName:_name associations:_config template:_c])) {
     self->list              = OWGetProperty(_config, @"list");
     self->item              = OWGetProperty(_config, @"item");

diff --git a/sope-appserver/NGObjWeb/Version b/sope-appserver/NGObjWeb/Version
index cab29a95d48ddc2911a4d3032a431391bdae074f..0803e2fa4aaa6d37787363bdb0d2ff12737f1d67 100644 (file)
--- a/sope-appserver/NGObjWeb/Version
+++ b/sope-appserver/NGObjWeb/Version
@@ -1,6 +1,6 @@
 # version file
 
-SUBMINOR_VERSION:=218
+SUBMINOR_VERSION:=219
 
 # v4.5.214 requires libNGExtensions v4.5.179
 # v4.5.122 requires libNGExtensions v4.5.153

diff --git a/sope-appserver/NGObjWeb/WOComponent.m b/sope-appserver/NGObjWeb/WOComponent.m
index 39a115f71c3d81e8487236c3b3ece41ef59891c8..e188d7a1ef0b9954e3a2777ac06f26e2b384053c 100644 (file)
--- a/sope-appserver/NGObjWeb/WOComponent.m
+++ b/sope-appserver/NGObjWeb/WOComponent.m
@@ -401,7 +401,7 @@ static inline id _getExtraVar(WOComponent *self, NSString *_key) {
 }
 
 - (id)existingSession {
-  if (self->session)
+  if (self->session != nil)
     return self->session;
   
   if ([[self context] hasSession])

diff --git a/sope-appserver/NGObjWeb/WODirectAction.m b/sope-appserver/NGObjWeb/WODirectAction.m
index fa159822bfebf2d0a9d5a9b6c7893ae5868850b1..992b4cacfa224dff5f48de649c36af9934195161 100644 (file)
--- a/sope-appserver/NGObjWeb/WODirectAction.m
+++ b/sope-appserver/NGObjWeb/WODirectAction.m
@@ -40,7 +40,7 @@
 }
 
 - (id)initWithRequest:(WORequest *)_request {
-  if ((self = [super init])) {
+  if ((self = [super init]) != nil) {
   }
   return self;
 }