Add a couple of XXX comments

git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@1072 d4fa192b-c00b-0410-8231-f00ffab90ce4

diff --git a/varnish-cache/bin/varnishd/cache_center.c b/varnish-cache/bin/varnishd/cache_center.c
index 2b8bd2ed3df7de314202abada531af1dedde4e0b..af9cc631553b1edb140ba827ba10eddc035ccefe 100644 (file)
--- a/varnish-cache/bin/varnishd/cache_center.c
+++ b/varnish-cache/bin/varnishd/cache_center.c
@@ -303,6 +303,13 @@ cnt_first(struct sess *sp)
 {
        int i;
 
+       /*
+        * XXX: If we don't have acceptfilters we are somewhat subject
+        * XXX: to DoS'ing here.  One remedy would be to set a shorter
+        * XXX: SO_RCVTIMEO and once we have received something here
+        * XXX: increase it to the normal value.
+        */
+
        assert(sp->xid == 0);
        VCA_Prep(sp);
        sp->wrk->idle = sp->t_open.tv_sec;

diff --git a/varnish-cache/bin/varnishd/cache_pool.c b/varnish-cache/bin/varnishd/cache_pool.c
index edbb04433a92ce5d79a629d9edc5caa17f739b9e..c529cb4acf9639ee04d1e06b46f321fea912ae82 100644 (file)
--- a/varnish-cache/bin/varnishd/cache_pool.c
+++ b/varnish-cache/bin/varnishd/cache_pool.c
@@ -275,6 +275,12 @@ WRK_QueueSession(struct sess *sp)
        UNLOCK(&qp->mtx);
 
        LOCK(&tmtx);
+       /*
+        * XXX: If there are too many requests in the overflow queue
+        * XXX: we should kill the request right here. 
+        * XXX: Not sure how though.  Simply closing may be the better
+        * XXX: compromise.
+        */
        TAILQ_INSERT_TAIL(&overflow, &sp->workreq, list);
        VSL_stats->n_wrk_overflow++;
        VSL_stats->n_wrk_queue++;