]> err.no Git - linux-2.6/commitdiff
Revert quicklist need->flush fix
authorChristoph Lameter <clameter@sgi.com>
Wed, 26 Dec 2007 20:43:01 +0000 (12:43 -0800)
committerLinus Torvalds <torvalds@woody.linux-foundation.org>
Thu, 27 Dec 2007 06:04:09 +0000 (22:04 -0800)
Did not fix the reported issue. Apart from other weirdness this causes a
bad link between the TLB flushing logic and the quicklists. If there is
indeed an issue that an arch needs a tlb flush before free then the arch
code needs to set tlb->need_flush before calling quicklist_free.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
include/asm-generic/tlb.h

index 799307eea40ffcc6efe6484a670737c09fa7478a..75f2bfab614f40639090702a2a6268f34864df75 100644 (file)
@@ -86,9 +86,6 @@ tlb_flush_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
 static inline void
 tlb_finish_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
 {
-#ifdef CONFIG_QUICKLIST
-       tlb->need_flush += &__get_cpu_var(quicklist)[0].nr_pages != 0;
-#endif
        tlb_flush_mmu(tlb, start, end);
 
        /* keep the page table cache within bounds */