]> err.no Git - linux-2.6/commitdiff
slub: Move map/flag clearing to __free_slab
authorChristoph Lameter <clameter@sgi.com>
Mon, 14 Apr 2008 15:52:18 +0000 (18:52 +0300)
committerPekka Enberg <penberg@cs.helsinki.fi>
Mon, 14 Apr 2008 15:52:18 +0000 (18:52 +0300)
__free_slab does some diagnostics. The resetting of mapcount etc
in discard_slab() can interfere with debug processing. So move
the reset immediately before the page is freed.

Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
mm/slub.c

index 23e5ee7b149fcc3a1fbc34ff2a48e4a764ce6a8b..f924cffb29e793e8f8713d2071d473df1658cb01 100644 (file)
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -1125,6 +1125,8 @@ static void __free_slab(struct kmem_cache *s, struct page *page)
                NR_SLAB_RECLAIMABLE : NR_SLAB_UNRECLAIMABLE,
                -pages);
 
+       __ClearPageSlab(page);
+       reset_page_mapcount(page);
        __free_pages(page, s->order);
 }
 
@@ -1154,8 +1156,6 @@ static void discard_slab(struct kmem_cache *s, struct page *page)
        struct kmem_cache_node *n = get_node(s, page_to_nid(page));
 
        atomic_long_dec(&n->nr_slabs);
-       reset_page_mapcount(page);
-       __ClearPageSlab(page);
        free_slab(s, page);
 }