]> err.no Git - linux-2.6/commitdiff
V4L/DVB (5123): Buf_qbuf: fix: videobuf_queue->stream corruption and lockup
authorOleg Nesterov <oleg@tv-sign.ru>
Tue, 23 Jan 2007 23:04:13 +0000 (20:04 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 24 Jan 2007 00:00:21 +0000 (22:00 -0200)
We are doing ->buf_prepare(buf) before adding buf to q->stream list. This
means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/video-buf.c

index 635d102c86f0e5945ec6d19afadf5743dcc5a037..6504a5866849ab73d6058304d9b7dd91b9c85db7 100644 (file)
@@ -700,6 +700,7 @@ videobuf_qbuf(struct videobuf_queue *q,
                goto done;
        }
        if (buf->state == STATE_QUEUED ||
+           buf->state == STATE_PREPARED ||
            buf->state == STATE_ACTIVE) {
                dprintk(1,"qbuf: buffer is already queued or active.\n");
                goto done;