]> err.no Git - linux-2.6/commitdiff
[SCSI] zfcp: Reduce flood on hba trace
authorChristof Schmitt <christof.schmitt@de.ibm.com>
Mon, 5 Nov 2007 11:37:48 +0000 (12:37 +0100)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Sat, 12 Jan 2008 00:22:40 +0000 (18:22 -0600)
Remove tracing for request with a "qualifier" field set in the
response.  The protocol status qualifier now contains measurement
data for "good" commands, so this check would trace every response
by default.

The fix is to simply remove the "qual" tracing: The responses with an
interesting status are also traced as "ferr" or "perr" and all
responses can be traced as "norm" with a higher trace level.

Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/s390/scsi/zfcp_dbf.c

index ffa3bf756943f6aa142c8bf66bc74e70de1c3fc5..701046c9bb330ef8dc1ca6d0a76516755a5687ea 100644 (file)
@@ -161,12 +161,6 @@ void zfcp_hba_dbf_event_fsf_response(struct zfcp_fsf_req *fsf_req)
                   (fsf_req->fsf_command == FSF_QTCB_OPEN_LUN)) {
                strncpy(rec->tag2, "open", ZFCP_DBF_TAG_SIZE);
                level = 4;
-       } else if ((prot_status_qual->doubleword[0] != 0) ||
-                  (prot_status_qual->doubleword[1] != 0) ||
-                  (fsf_status_qual->doubleword[0] != 0) ||
-                  (fsf_status_qual->doubleword[1] != 0)) {
-               strncpy(rec->tag2, "qual", ZFCP_DBF_TAG_SIZE);
-               level = 3;
        } else {
                strncpy(rec->tag2, "norm", ZFCP_DBF_TAG_SIZE);
                level = 6;