]> err.no Git - linux-2.6/commitdiff
[NET]: drop duplicate assignment in request_sock
authorNorbert Kiesel <nkiesel@tbdnetworks.com>
Mon, 27 Mar 2006 01:39:55 +0000 (17:39 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Mar 2006 01:39:55 +0000 (17:39 -0800)
Just noticed that request_sock.[ch] contain a useless assignment of
rskq_accept_head to itself.  I assume this is a typo and the 2nd one
was supposed to be _tail.  However, setting _tail to NULL is not
needed, so the patch below just drops the 2nd assignment.

Signed-off-By: Norbert Kiesel <nkiesel@tbdnetworks.com>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/request_sock.h
net/core/request_sock.c

index 11641c9384f78ae48f5a41272f223066102cc96c..c5d7f920c352d074285ed6d57563c54357450845 100644 (file)
@@ -145,7 +145,7 @@ static inline struct request_sock *
 {
        struct request_sock *req = queue->rskq_accept_head;
 
-       queue->rskq_accept_head = queue->rskq_accept_head = NULL;
+       queue->rskq_accept_head = NULL;
        return req;
 }
 
index 98f0fc923f9195326ed9d0fe538e58fd7528d8d7..1e44eda1fda9f028bb3e9d67c06a4d6dda30311e 100644 (file)
@@ -51,7 +51,7 @@ int reqsk_queue_alloc(struct request_sock_queue *queue,
 
        get_random_bytes(&lopt->hash_rnd, sizeof(lopt->hash_rnd));
        rwlock_init(&queue->syn_wait_lock);
-       queue->rskq_accept_head = queue->rskq_accept_head = NULL;
+       queue->rskq_accept_head = NULL;
        lopt->nr_table_entries = nr_table_entries;
 
        write_lock_bh(&queue->syn_wait_lock);