]> err.no Git - dak/commitdiff
Update comment about our monkeypatching of commands.getstatusoutput.
authorChris Lamb <lamby@debian.org>
Fri, 30 Oct 2009 13:49:48 +0000 (13:49 +0000)
committerChris Lamb <lamby@debian.org>
Fri, 30 Oct 2009 14:29:58 +0000 (14:29 +0000)
Signed-off-by: Chris Lamb <lamby@debian.org>
daklib/utils.py

index 0c628fb4a67b0479de35d2136125077c827d6738..50a0682dbedcfac93cb555757a8e20275e7b7ef4 100755 (executable)
@@ -62,8 +62,9 @@ key_uid_email_cache = {}  #: Cache for email addresses from gpg key uids
 known_hashes = [("sha1", apt_pkg.sha1sum, (1, 8)),
                 ("sha256", apt_pkg.sha256sum, (1, 8))] #: hashes we accept for entries in .changes/.dsc
 
-# Monkeypatch commands.getstatusoutput as it returns a "0" exit code in
-# all situations under lenny's Python.
+# Monkeypatch commands.getstatusoutput as it may not return the correct exit
+# code in lenny's Python. This also affects commands.getoutput and
+# commands.getstatus.
 def dak_getstatusoutput(cmd):
     pipe = subprocess.Popen(cmd, shell=True, universal_newlines=True,
         stdout=subprocess.PIPE, stderr=subprocess.STDOUT)