]> err.no Git - linux-2.6/commitdiff
[SCSI] zfcp: correctly set this_id for hosts
authorAndreas Herrmann <aherrman@de.ibm.com>
Thu, 2 Mar 2006 20:28:54 +0000 (21:28 +0100)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Fri, 3 Mar 2006 04:45:40 +0000 (22:45 -0600)
It fixes a bug in zfcp which provokes a race
in scsi_scan.c. Finally this can lead to an Oops like:

kernel BUG at fs/sysfs/symlink.c:87!

Correctly set this_id for the host. Otherwise we provoke
a race between scsi_target_reap_work and concurrent
scsi_add_device.

Signed-off-by: Andreas Herrmann <aherrman@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/s390/scsi/zfcp_scsi.c

index 9f6b4d7a46f3342a2b853ee0d501b37e46b3b846..a2de3c9afe4914869a089f50ec4a58084840c513 100644 (file)
@@ -68,7 +68,7 @@ struct zfcp_data zfcp_data = {
              eh_host_reset_handler:   zfcp_scsi_eh_host_reset_handler,
                                       /* FIXME(openfcp): Tune */
              can_queue:               4096,
-             this_id:                 0,
+             this_id:                 -1,
              /*
               * FIXME:
               * one less? can zfcp_create_sbale cope with it?