]> err.no Git - linux-2.6/commitdiff
V4L/DVB (5415): Msp_attach must return 0 if no msp3400 was found.
authorHans Verkuil <hverkuil@xs4all.nl>
Sat, 10 Mar 2007 23:21:07 +0000 (20:21 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Tue, 27 Mar 2007 11:45:55 +0000 (08:45 -0300)
Returning -1 causes the probe to stop, but it should just continue
instead.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/msp3400-driver.c

index 2fb9fe6a1ae75ac39ea0a3865749459962adfeb5..91078c0d8feacd9a86fe402b24d16f855e2fe9da 100644 (file)
@@ -825,7 +825,7 @@ static int msp_attach(struct i2c_adapter *adapter, int address, int kind)
        if (msp_reset(client) == -1) {
                v4l_dbg(1, msp_debug, client, "msp3400 not found\n");
                kfree(client);
-               return -1;
+               return 0;
        }
 
        state = kmalloc(sizeof(*state), GFP_KERNEL);
@@ -859,7 +859,7 @@ static int msp_attach(struct i2c_adapter *adapter, int address, int kind)
                v4l_dbg(1, msp_debug, client, "not an msp3400 (cannot read chip version)\n");
                kfree(state);
                kfree(client);
-               return -1;
+               return 0;
        }
 
        msp_set_audio(client);