]> err.no Git - linux-2.6/commitdiff
b43: debugfs SHM read buffer overrun fix
authorMichael Buesch <mb@bu3sch.de>
Fri, 2 Nov 2007 17:35:02 +0000 (18:35 +0100)
committerJeff Garzik <jeff@garzik.org>
Sat, 10 Nov 2007 09:25:12 +0000 (04:25 -0500)
Fix possible buffer overrun.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/b43/debugfs.c

index 734e70e1a06d557411b0273d24cf3399d1c6f6be..ef0075d9f9cb81b323425baf56b18fd5523ac067 100644 (file)
@@ -128,7 +128,7 @@ static ssize_t shm_read_file(struct b43_wldev *dev,
        __le16 *le16buf = (__le16 *)buf;
 
        for (i = 0; i < 0x1000; i++) {
-               if (bufsize <= 0)
+               if (bufsize < sizeof(tmp))
                        break;
                tmp = b43_shm_read16(dev, B43_SHM_SHARED, 2 * i);
                le16buf[i] = cpu_to_le16(tmp);