]> err.no Git - linux-2.6/commitdiff
[PATCH] ppc64: Fix typo bug in iSeries hash code
authorDavid Gibson <david@gibson.dropbear.id.au>
Fri, 21 Oct 2005 03:41:19 +0000 (13:41 +1000)
committerLinus Torvalds <torvalds@g5.osdl.org>
Fri, 21 Oct 2005 19:24:41 +0000 (12:24 -0700)
This fixes a stupid typo bug in the iSeries hash table code.

When we place a hash PTE in the secondary bucket, instead of setting the
SECONDARY flag bit, as we should, we (redundantly) set the VALID flag.

This was introduced with the patch abolishing bitfields from the hash
table code.  Mea culpa, oops.  It hasn't been noticed until now because
in practice we don't hit the secondary bucket terribly often.

Signed-off-by: David Gibson <dwg@au1.ibm.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
arch/ppc64/kernel/iSeries_htab.c

index 2192055a90a07ba3f34f074e70cb75225d124fdb..073b766617474dd9741ed8e79638e6b9ad5fcbf0 100644 (file)
@@ -66,7 +66,7 @@ static long iSeries_hpte_insert(unsigned long hpte_group, unsigned long va,
        }
 
        if (slot < 0) {         /* MSB set means secondary group */
-               vflags |= HPTE_V_VALID;
+               vflags |= HPTE_V_SECONDARY;
                secondary = 1;
                slot &= 0x7fffffffffffffff;
        }