]> err.no Git - linux-2.6/commitdiff
[PKT_SCHED]: GRED: Do not reset statistics in gred_reset/gred_change
authorThomas Graf <tgraf@suug.ch>
Sat, 5 Nov 2005 20:14:17 +0000 (21:14 +0100)
committerThomas Graf <tgr@axs.localdomain>
Sat, 5 Nov 2005 21:02:27 +0000 (22:02 +0100)
Qdiscs are not supposed to reset statistics in reset() and while
changing parameters. My argumentation is that if the user wants
the counters to be reset he can simply remove and readd the
qdiscs, that's what most users do anyway.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
net/sched/sch_gred.c

index a52490c7af3cb71f7a1c9df3f655219fb2a3bf0a..50f184cd7f1fd947fec7102ca7bae4025ab88365 100644 (file)
@@ -348,10 +348,6 @@ static void gred_reset(struct Qdisc* sch)
                        continue; 
                red_restart(&q->parms);
                q->backlog = 0;
-               q->stats.other = 0;
-               q->stats.forced_drop = 0;
-               q->stats.prob_drop = 0;
-               q->stats.pdrop = 0;
        }
 }
 
@@ -434,11 +430,6 @@ static inline int gred_change_vq(struct Qdisc *sch, int dp,
                      ctl->qth_min, ctl->qth_max, ctl->Wlog, ctl->Plog,
                      ctl->Scell_log, stab);
 
-       q->stats.other = 0;
-       q->stats.forced_drop = 0;
-       q->stats.prob_drop = 0;
-       q->stats.pdrop = 0;
-
        return 0;
 }