Don't access uninitialised memory

Trivial fix to make sure we allocate memory before trying to access
where a pointer points.

diff --git a/lib/myopt.c b/lib/myopt.c
index 3a066c937e152211c25eb5ac4912e5c8984a075a..64d4122c66390d2114e298a71909860961a81e13 100644 (file)
--- a/lib/myopt.c
+++ b/lib/myopt.c
@@ -185,6 +185,11 @@ void loadfilter(char *fn) {
   while (fgets(linebuf, sizeof(linebuf), file)) {
     struct filterlist *filter;
 
+    filter = malloc(sizeof(struct filterlist));
+    if (!filter) {
+      ohshite(_("Error allocating memory for filter entry"));
+    }
+
     if (linebuf[0] == '#' || linebuf[0] == '\n') {
       continue;
     }
@@ -198,11 +203,8 @@ void loadfilter(char *fn) {
       filter->positive = 0;
     } else {
       warningf(_("Invalid filter line: `%.255s'"), linebuf);
-    }
-
-    filter = malloc(sizeof(struct filterlist));
-    if (!filter) {
-      ohshite(_("Error allocating memory for filter entry"));
+      free(filter);
+      continue;
     }
 
     filter->filterstring = malloc(strlen(linebuf));