]> err.no Git - linux-2.6/commitdiff
rt2x00: Don't use uninitialized desc_len
authorIvo van Doorn <ivdoorn@gmail.com>
Sun, 9 Mar 2008 21:40:06 +0000 (22:40 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 13 Mar 2008 20:02:34 +0000 (16:02 -0400)
skbdesc->desc_len is uninitialized at the start
of the function. So it is a _bad_ idea to use it...

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt73usb.c

index b4b70850edfccde0821eafb3e9d833760cef049b..a48c82f09216fec9641fb5d0abf0370639bc1064 100644 (file)
@@ -1381,7 +1381,7 @@ static void rt73usb_fill_rxdone(struct queue_entry *entry,
        skb_push(entry->skb, offset);
        memcpy(entry->skb->data, rxd, entry->queue->desc_size);
        rxd = (__le32 *)entry->skb->data;
-       skb_pull(entry->skb, offset + skbdesc->desc_len);
+       skb_pull(entry->skb, offset + entry->queue->desc_size);
        skb_trim(entry->skb, rxdesc->size);
 
        /*