]> err.no Git - linux-2.6/commitdiff
sh: Workaround for __put_user_asm() bug with gcc 4.x on big-endian.
authorYoshinori Sato <ysato@users.sourceforge.jp>
Mon, 28 Jul 2008 09:36:13 +0000 (18:36 +0900)
committerPaul Mundt <lethal@linux-sh.org>
Mon, 28 Jul 2008 09:36:13 +0000 (18:36 +0900)
I think this problem is GCC(4.1.2) bug.
Syscall "getdents" returned "dirent->d_off" is always 0.
I think other EB enviroment have same problem.

Problem code
0c03c954 <filldir>:
 :
 c03c97a:       58 f7           mov.l   @(28,r15),r8 !-> offset (high)
 c03c97c:       59 f8           mov.l   @(32,r15),r9 !-> offset (low)
 c03c97e:       53 f9           mov.l   @(36,r15),r3
 c03c980:       54 fa           mov.l   @(40,r15),r4
 :
 c03c9a0:       21 82           mov.l   r8,@r1 !offset(high) -> dirent->d_off

It's workaround patch.

Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
include/asm-sh/uaccess_32.h

index ae0d24f6653f8ee1979d4d369b5e8fac9480beb1..892fd6dea9dbb355c432b63ecd699bb9ffb6ae57 100644 (file)
@@ -76,7 +76,8 @@ do {                                                  \
                __put_user_asm(x, ptr, retval, "w");    \
                break;                                  \
        case 4:                                         \
-               __put_user_asm(x, ptr, retval, "l");    \
+               __put_user_asm((u32)x, ptr,             \
+                              retval, "l");            \
                break;                                  \
        case 8:                                         \
                __put_user_u64(x, ptr, retval);         \