]> err.no Git - linux-2.6/commitdiff
sk98lin: handle pci_enable_device() return value in skge_resume()
authorDmitriy Monakhov <dmonakhov@openvz.org>
Tue, 6 Mar 2007 10:42:01 +0000 (02:42 -0800)
committerJeff Garzik <jeff@garzik.org>
Sat, 28 Apr 2007 15:00:57 +0000 (11:00 -0400)
Signed-off-by: Monakhov Dmitriy <dmonakhov@openvz.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/sk98lin/skge.c

index e0a93005e6dce369a788fa82af9d40fd803ace33..bf218621db16003ba393c284579c2f68727349af 100644 (file)
@@ -5123,7 +5123,12 @@ static int skge_resume(struct pci_dev *pdev)
 
        pci_set_power_state(pdev, PCI_D0);
        pci_restore_state(pdev);
-       pci_enable_device(pdev);
+       ret = pci_enable_device(pdev);
+       if (ret) {
+               printk(KERN_WARNING "sk98lin: unable to enable device %s "
+                               "in resume\n", dev->name);
+               goto err_out;
+       }
        pci_set_master(pdev);
        if (pAC->GIni.GIMacsFound == 2)
                ret = request_irq(dev->irq, SkGeIsr, IRQF_SHARED, "sk98lin", dev);
@@ -5131,10 +5136,8 @@ static int skge_resume(struct pci_dev *pdev)
                ret = request_irq(dev->irq, SkGeIsrOnePort, IRQF_SHARED, "sk98lin", dev);
        if (ret) {
                printk(KERN_WARNING "sk98lin: unable to acquire IRQ %d\n", dev->irq);
-               pAC->AllocFlag &= ~SK_ALLOC_IRQ;
-               dev->irq = 0;
-               pci_disable_device(pdev);
-               return -EBUSY;
+               ret = -EBUSY;
+               goto err_out_disable_pdev;
        }
 
        netif_device_attach(dev);
@@ -5151,6 +5154,13 @@ static int skge_resume(struct pci_dev *pdev)
        }
 
        return 0;
+
+err_out_disable_pdev:
+       pci_disable_device(pdev);
+err_out:
+       pAC->AllocFlag &= ~SK_ALLOC_IRQ;
+       dev->irq = 0;
+       return ret;
 }
 #else
 #define skge_suspend NULL