]> err.no Git - linux-2.6/commitdiff
USB: fix mistake in usb_hcd_giveback_urb
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 22 Aug 2007 17:06:53 +0000 (13:06 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 21:55:19 +0000 (14:55 -0700)
This patch (as971) fixes a small mistake: The URB's completion status
needs to be adjusted before the URB is passed to usmon_urb_complete(),
not afterward.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd.c

index ec17fc4d28614462ea7f93da338bf9972bca9423..8b17babf5c55b8c2e47e23f7c05b43146ce5dcca 100644 (file)
@@ -1266,9 +1266,6 @@ int usb_hcd_unlink_urb (struct urb *urb, int status)
  */
 void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb)
 {
-       unmap_urb_for_dma(hcd, urb);
-       usbmon_urb_complete (&hcd->self, urb);
-       usb_unanchor_urb(urb);
        urb->hcpriv = NULL;
        if (unlikely(urb->unlinked))
                urb->status = urb->unlinked;
@@ -1277,6 +1274,10 @@ void usb_hcd_giveback_urb (struct usb_hcd *hcd, struct urb *urb)
                        !urb->status))
                urb->status = -EREMOTEIO;
 
+       unmap_urb_for_dma(hcd, urb);
+       usbmon_urb_complete(&hcd->self, urb);
+       usb_unanchor_urb(urb);
+
        /* pass ownership to the completion handler */
        urb->complete (urb);
        atomic_dec (&urb->use_count);