]> err.no Git - linux-2.6/commitdiff
[GFS2] Lockup on error
authorBob Peterson <rpeterso@redhat.com>
Sun, 20 Jan 2008 03:50:24 +0000 (21:50 -0600)
committerSteven Whitehouse <swhiteho@redhat.com>
Fri, 25 Jan 2008 08:21:04 +0000 (08:21 +0000)
I spotted this bug while I was digging around.  Looks like it could cause
a lockup in some rare error condition.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/inode.c

index c84764ad82b36982a3b13155941b2ad5a4b7cab6..728d3169e7bd5b32b112bf29852d52c394ef6915 100644 (file)
@@ -860,7 +860,7 @@ static int link_dinode(struct gfs2_inode *dip, const struct qstr *name,
 
        error = alloc_required = gfs2_diradd_alloc_required(&dip->i_inode, name);
        if (alloc_required < 0)
-               goto fail;
+               goto fail_quota_locks;
        if (alloc_required) {
                error = gfs2_quota_check(dip, dip->i_inode.i_uid, dip->i_inode.i_gid);
                if (error)