]> err.no Git - linux-2.6/commitdiff
usb-net/pegasus: simplify carrier detection
authorDan Williams <dcbw@redhat.com>
Thu, 26 Apr 2007 01:30:29 +0000 (21:30 -0400)
committerJeff Garzik <jeff@garzik.org>
Sat, 28 Apr 2007 00:16:41 +0000 (20:16 -0400)
Simplify pegasus carrier detection; rely only on the periodic MII
polling.  Reverts pieces of c43c49bd61fdb9bb085ddafcaadb17d06f95ec43.

Signed-off-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/usb/net/pegasus.c
drivers/usb/net/pegasus.h

index 1ad4ee54b18691727ae3718e0bd5db762cb69d4e..a05fd97e5bc2e0c98b67664142767501611cd293 100644 (file)
@@ -847,16 +847,6 @@ static void intr_callback(struct urb *urb)
                 * d[0].NO_CARRIER kicks in only with failed TX.
                 * ... so monitoring with MII may be safest.
                 */
-               if (pegasus->features & TRUST_LINK_STATUS) {
-                       if (d[5] & LINK_STATUS)
-                               netif_carrier_on(net);
-                       else
-                               netif_carrier_off(net);
-               } else {
-                       /* Never set carrier _on_ based on ! NO_CARRIER */
-                       if (d[0] & NO_CARRIER)
-                               netif_carrier_off(net); 
-               }
 
                /* bytes 3-4 == rx_lostpkt, reg 2E/2F */
                pegasus->stats.rx_missed_errors += ((d[3] & 0x7f) << 8) | d[4];
index c7aadb413e8c3d5a1b95d121cdfc9085c99722c7..c7467823cd1ca975349ec5ddfdac2ed293d7beac 100644 (file)
@@ -11,7 +11,6 @@
 
 #define        PEGASUS_II              0x80000000
 #define        HAS_HOME_PNA            0x40000000
-#define        TRUST_LINK_STATUS       0x20000000
 
 #define        PEGASUS_MTU             1536
 #define        RX_SKBS                 4
@@ -204,7 +203,7 @@ PEGASUS_DEV( "AEI USB Fast Ethernet Adapter", VENDOR_AEILAB, 0x1701,
 PEGASUS_DEV( "Allied Telesyn Int. AT-USB100", VENDOR_ALLIEDTEL, 0xb100,
                DEFAULT_GPIO_RESET | PEGASUS_II )
 PEGASUS_DEV( "Belkin F5D5050 USB Ethernet", VENDOR_BELKIN, 0x0121,
-               DEFAULT_GPIO_RESET | PEGASUS_II | TRUST_LINK_STATUS )
+               DEFAULT_GPIO_RESET | PEGASUS_II )
 PEGASUS_DEV( "Billionton USB-100", VENDOR_BILLIONTON, 0x0986,
                DEFAULT_GPIO_RESET )
 PEGASUS_DEV( "Billionton USBLP-100", VENDOR_BILLIONTON, 0x0987,