]> err.no Git - linux-2.6/commitdiff
[POWERPC] of_serial: Ignore unknown serial port
authorIshizaki Kou <kou.ishizaki@toshiba.co.jp>
Thu, 31 May 2007 09:30:33 +0000 (19:30 +1000)
committerPaul Mackerras <paulus@samba.org>
Tue, 10 Jul 2007 11:53:41 +0000 (21:53 +1000)
Current of_serial driver assumes unknown serial port to be 8250.  But
this behavior may cause fatal problems when the serial port is not
8250.  This corrects probe routine to ignore unknown serial port.

Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Paul Mackerras <paulus@samba.org>
drivers/serial/of_serial.c

index 7ffdaeaf0545e2201803322a1b6959bd73feb3d8..d7752af1c7ecb2e083a5cb0a4707ab63255b2fa3 100644 (file)
@@ -75,15 +75,13 @@ static int __devinit of_platform_serial_probe(struct of_device *ofdev,
                goto out;
 
        switch (port_type) {
-       case PORT_UNKNOWN:
-               dev_info(&ofdev->dev, "Unknown serial port found, "
-                       "attempting to use 8250 driver\n");
-               /* fallthrough */
        case PORT_8250 ... PORT_MAX_8250:
                ret = serial8250_register_port(&port);
                break;
        default:
                /* need to add code for these */
+       case PORT_UNKNOWN:
+               dev_info(&ofdev->dev, "Unknown serial port found, ignored\n");
                ret = -ENODEV;
                break;
        }