]> err.no Git - linux-2.6/commitdiff
[NET]: Remove bogus zero_it argument from sk_alloc
authorPavel Emelyanov <xemul@openvz.org>
Thu, 1 Nov 2007 07:38:43 +0000 (00:38 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 1 Nov 2007 07:38:43 +0000 (00:38 -0700)
At this point nobody calls the sk_alloc(() with zero_it == 0,
so remove unneeded checks from it.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/sock.c

index 4f4708a6ff8fb1aa5c9cc8b6ba2e638ebb944191..6046fc69428b0db3da2058ce1bde63511c90b7df 100644 (file)
@@ -931,21 +931,16 @@ struct sock *sk_alloc(struct net *net, int family, gfp_t priority,
 {
        struct sock *sk;
 
-       if (zero_it)
-               priority |= __GFP_ZERO;
-
-       sk = sk_prot_alloc(prot, priority, family);
+       sk = sk_prot_alloc(prot, priority | __GFP_ZERO, family);
        if (sk) {
-               if (zero_it) {
-                       sk->sk_family = family;
-                       /*
-                        * See comment in struct sock definition to understand
-                        * why we need sk_prot_creator -acme
-                        */
-                       sk->sk_prot = sk->sk_prot_creator = prot;
-                       sock_lock_init(sk);
-                       sk->sk_net = get_net(net);
-               }
+               sk->sk_family = family;
+               /*
+                * See comment in struct sock definition to understand
+                * why we need sk_prot_creator -acme
+                */
+               sk->sk_prot = sk->sk_prot_creator = prot;
+               sock_lock_init(sk);
+               sk->sk_net = get_net(net);
        }
 
        return sk;