]> err.no Git - linux-2.6/commitdiff
USB: test for NULL return from platform_get_resource() in ohci_hcd_sm501_drv_remove()
authorJesper Juhl <jesper.juhl@gmail.com>
Fri, 21 Mar 2008 21:55:45 +0000 (22:55 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 25 Apr 2008 04:16:45 +0000 (21:16 -0700)
platform_get_resource() may return null, so although it seems it will never
do so here unless there's a bug elsewhere, it does no harm to be defensive
and test.

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
Acked-by: Magnus Damm <magnus.damm@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/ohci-sm501.c

index ab1e366d7790e718da9b75bec531fd75b499c330..54b6ac2e3e4aa6ddd210ecef1f89fb11427a25a3 100644 (file)
@@ -199,7 +199,8 @@ static int ohci_hcd_sm501_drv_remove(struct platform_device *pdev)
        usb_put_hcd(hcd);
        dma_release_declared_memory(&pdev->dev);
        mem = platform_get_resource(pdev, IORESOURCE_MEM, 1);
-       release_mem_region(mem->start, mem->end - mem->start + 1);
+       if (mem)
+               release_mem_region(mem->start, mem->end - mem->start + 1);
 
        /* mask interrupts and disable power */