]> err.no Git - linux-2.6/commitdiff
[FIB]: Reduce text size of net/ipv4/fib_trie.o
authorEric Dumazet <dada1@cosmosbay.com>
Sun, 13 Jan 2008 05:27:41 +0000 (21:27 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Jan 2008 23:01:58 +0000 (15:01 -0800)
In struct tnode, we use two fields of 5 bits for 'pos' and 'bits'.
Switching to plain 'unsigned char' (8 bits) take the same space
because of compiler alignments, and reduce text size by 435 bytes
on i386.

On i386 :
$ size net/ipv4/fib_trie.o.before_patch net/ipv4/fib_trie.o
    text    data     bss     dec     hex filename
   13714       4      64   13782    35d6 net/ipv4/fib_trie.o.before
   13279       4      64   13347    3423 net/ipv4/fib_trie.o

Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Acked-by: Stephen Hemminger <stephen.hemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_trie.c

index 3e94a4dddb0c69b76f4c85aadbc668eaaf4b0b54..350904c233ee343b5375decd6d8b67d898daa996 100644 (file)
@@ -118,8 +118,8 @@ struct leaf_info {
 struct tnode {
        t_key key;
        unsigned long parent;
-       unsigned short pos:5;           /* 2log(KEYLENGTH) bits needed */
-       unsigned short bits:5;          /* 2log(KEYLENGTH) bits needed */
+       unsigned char pos;              /* 2log(KEYLENGTH) bits needed */
+       unsigned char bits;             /* 2log(KEYLENGTH) bits needed */
        unsigned short full_children;   /* KEYLENGTH bits needed */
        unsigned short empty_children;  /* KEYLENGTH bits needed */
        struct rcu_head rcu;