]> err.no Git - linux-2.6/commitdiff
drivers/net/arm/at91_ether.c: logical/bitand typo in function reset_phy()
authorRoel Kluin <12o3l@tiscali.nl>
Tue, 29 Jan 2008 20:14:56 +0000 (21:14 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 3 Feb 2008 12:28:36 +0000 (04:28 -0800)
include/linux/mii.h:48:#define BMCR_RESET 0x8000

The function reset_phy() is in "#if 0" inactivated code

Replace logical "&&" by bit "&" before BMCR_RESET

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/arm/at91_ether.c

index 25b114a4e2b16f57373481da83b6066090518543..0ae0d83e5d2254b1db9b531103a3f88d4b50b7e3 100644 (file)
@@ -384,7 +384,7 @@ static void reset_phy(struct net_device *dev)
        /* Wait until PHY reset is complete */
        do {
                read_phy(lp->phy_address, MII_BMCR, &bmcr);
-       } while (!(bmcr && BMCR_RESET));
+       } while (!(bmcr & BMCR_RESET));
 
        disable_mdi();
        spin_unlock_irq(&lp->lock);