some work on mailer contacts

git-svn-id: http://svn.opengroupware.org/SOGo/trunk@564 d1b88da0-ebda-0310-925b-ed51d893ca5b

diff --git a/SOGo/UI/MailerContacts/ChangeLog b/SOGo/UI/MailerContacts/ChangeLog
index e16ebd0ccdd3594f92caaac9bd0af5390ed756c8..f2b137b28551a89c55a255b4e9de0a73f31c8957 100644 (file)
--- a/SOGo/UI/MailerContacts/ChangeLog
+++ b/SOGo/UI/MailerContacts/ChangeLog
@@ -1,3 +1,7 @@
+2005-02-15  Helge Hess  <helge.hess@opengroupware.org>
+
+       * UIxMailContactEditor.m: added object title (v0.9.3)
+
 2005-02-14  Helge Hess  <helge.hess@opengroupware.org>
 
        * work on contact editor (v0.9.2)

diff --git a/SOGo/UI/MailerContacts/UIxMailContactEditor.m b/SOGo/UI/MailerContacts/UIxMailContactEditor.m
index 30f3f11e7e937bddc846ceac5c62f01a8bf7438f..e241cd0936f0a7c7c3705bd31b105ad42d354ffb 100644 (file)
--- a/SOGo/UI/MailerContacts/UIxMailContactEditor.m
+++ b/SOGo/UI/MailerContacts/UIxMailContactEditor.m
@@ -31,8 +31,24 @@
 
 @implementation UIxMailContactEditor
 
+/* title */
+
+- (NSString *)objectTitle {
+  NSString *l, *f;
+  
+  l = [self valueForKeyPath:@"snapshot.sn"];
+  f = [self valueForKeyPath:@"snapshot.givenName"];
+  if ([f length] == 0) return l;
+  if ([l length] == 0) return f;
+  return [[l stringByAppendingString:@", "] stringByAppendingString:f];
+}
 - (NSString *)panelTitle {
-  return [self labelForKey:@"Edit Contact"];
+  NSString *s;
+  
+  s = [self labelForKey:@"Edit Contact"];
+  s = [s stringByAppendingString:@": "];
+  s = [s stringByAppendingString:[self objectTitle]];
+  return s;
 }
 
 @end /* UIxMailContactEditor */

diff --git a/SOGo/UI/MailerContacts/UIxMailContactList.wox b/SOGo/UI/MailerContacts/UIxMailContactList.wox
index b86f46057fb662211f827c7e969f99287397af5c..e49a72fc063ea3d90dee0d2c8114ba4041810e46 100644 (file)
--- a/SOGo/UI/MailerContacts/UIxMailContactList.wox
+++ b/SOGo/UI/MailerContacts/UIxMailContactList.wox
@@ -84,15 +84,10 @@
 
         <!-- actual table contents -->
         <var:foreach list="contactInfos" item="contact">
-          <tr class="tableview" var:id="contact.cName">
-            <td class="mailer_listcell_regular">
-<!--
-              <a var:href="contact.cName"><var:string value="contact.sn" /></a>
--->
-              <a var:href="#" 
-                 onclick="openContact(this, this.parentNode.parentNode.id); return false"
-                 ><var:string value="contact.sn" /></a>
-            </td>
+          <tr class="tableview" var:id="contact.cName"
+              onclick="openContact(this, this.id)"
+          >
+            <td><var:string value="contact.sn"              /></td>
             <td><var:string value="contact.givenname"       /></td>
             <td><var:string value="contact.mail"            /></td>
             <td><var:string value="contact.telephonenumber" /></td>

diff --git a/SOGo/UI/MailerContacts/Version b/SOGo/UI/MailerContacts/Version
index ed045adfeab4736fa025a4a2ef062f6515fc7a9c..81d0f5a4cff3edc3be75e404954d4eed90c1bd38 100644 (file)
--- a/SOGo/UI/MailerContacts/Version
+++ b/SOGo/UI/MailerContacts/Version
@@ -1,3 +1,3 @@
 # version file
 
-SUBMINOR_VERSION:=2
+SUBMINOR_VERSION:=3

diff --git a/SOGo/UI/MailerContacts/mailercontacts.js b/SOGo/UI/MailerContacts/mailercontacts.js
index 70c00672c6f0684690826982c7414eef3f671e94..48863a0d16ecb4789278b87443a9398619e9b31f 100644 (file)
--- a/SOGo/UI/MailerContacts/mailercontacts.js
+++ b/SOGo/UI/MailerContacts/mailercontacts.js
@@ -21,8 +21,11 @@
 /* JavaScript code for SOGo MailerUI contacts */
 
 function openContact(sender, addruid) {
-  window.open(addruid + "/tb.edit", 'SOGo_addr_' + addruid,
-          'width=540,height=320,resizable=1,scrollbars=1,toolbar=0,' +
-          'location=0,directories=0,status=0,menubar=0,copyhistory=0')
+  var w;
+  
+  w = window.open(addruid + "/tb.edit", 'SOGo_addr_' + addruid,
+                 'width=540,height=320,resizable=1,scrollbars=1,toolbar=0,' +
+                 'location=0,directories=0,status=0,menubar=0,copyhistory=0');
+  w.focus();
   return false;
 }