]> err.no Git - linux-2.6/commitdiff
i2c-davinci: Remove useless IVR read
authorTroy Kisky <troy.kisky@boundarydevices.com>
Mon, 14 Jul 2008 20:38:20 +0000 (22:38 +0200)
committerJean Delvare <khali@mahadeva.delvare>
Mon, 14 Jul 2008 20:38:20 +0000 (22:38 +0200)
Interrupts are enabled at the point where the DAVINCI_I2C_IVR_REG is read,
so unless an interrupt happened just at that moment, no interrupt would be
pending. Even though documentation implies you should do this, I see no
reason. If slave support is added, this read would cause a hard to
reproduce bug.

Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
Signed-off-by: Kevin Hilman <khilman@mvista.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/busses/i2c-davinci.c

index 85097fdc75e4c7532785eef2251a095955fd4e9a..c56f8fe4efe5408bf200b8d55ceeb5abb20a63b5 100644 (file)
@@ -240,7 +240,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
        struct davinci_i2c_dev *dev = i2c_get_adapdata(adap);
        struct davinci_i2c_platform_data *pdata = dev->dev->platform_data;
        u32 flag;
-       u32 stat;
        u16 w;
        int r;
 
@@ -264,9 +263,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct i2c_msg *msg, int stop)
        init_completion(&dev->cmd_complete);
        dev->cmd_err = 0;
 
-       /* Clear any pending interrupts by reading the IVR */
-       stat = davinci_i2c_read_reg(dev, DAVINCI_I2C_IVR_REG);
-
        /* Take I2C out of reset, configure it as master and set the
         * start bit */
        flag = DAVINCI_I2C_MDR_IRS | DAVINCI_I2C_MDR_MST | DAVINCI_I2C_MDR_STT;