]> err.no Git - linux-2.6/commitdiff
rtl8180: fix wrong parameter in max2820_rf_set_channel
authorAndrea Merello <andrea.merello@gmail.com>
Sat, 10 May 2008 11:32:34 +0000 (13:32 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 28 May 2008 20:43:39 +0000 (16:43 -0400)
The max2820 RF code needs to invoke max2820_write_phy_antenna every time the
channel is being switch.

This should be done passing the channel number to that function.
Incorrectly we were passing the same value that is written on the
channel RF register.
This may cause problems when operating on ch 14.

This patch fixes it.

Thanks to Alessandro Di Marco who found this issue!

Signed-off-by: Andrea Merello <andreamrl@tiscali.it>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rtl8180_max2820.c

index a140c802264a70429b08343c25823d143b8ccb85..6c825fd7f3b6f86f0b677860980a852d5ff918e8 100644 (file)
@@ -88,7 +88,7 @@ static void max2820_rf_set_channel(struct ieee80211_hw *dev,
         * sa2400, for MAXIM we do this directly from BB */
        rtl8180_write_phy(dev, 3, txpw);
 
-       max2820_write_phy_antenna(dev, chan);
+       max2820_write_phy_antenna(dev, channel);
        write_max2820(dev, 3, chan);
 }