]> err.no Git - linux-2.6/commitdiff
[PATCH] Correct bound checking from the value returned from _PPC method.
authorDave Jones <davej@redhat.com>
Thu, 23 Nov 2006 01:42:01 +0000 (20:42 -0500)
committerLinus Torvalds <torvalds@woody.osdl.org>
Thu, 23 Nov 2006 17:18:55 +0000 (09:18 -0800)
processor_perflib.c::acpi_processor_ppc_notifier() check if the value
returned by the processor's _PPC method is 0 and return failed if so.
This is wrong since 0 indicate that the bios think the processor can go
to the highest frequency.  This patch for example fix the HP NX 6125 to
allow its highest frequency to be available.

Signed-off-by: Bruno Ducrot <ducrot@poupinou.org>
Cc: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/acpi/processor_perflib.c

index 7ba5e49ab302c523848930773d474c351fed30a1..6fd174a3714958946be4f4b54377c434694824e2 100644 (file)
@@ -83,10 +83,8 @@ static int acpi_processor_ppc_notifier(struct notifier_block *nb,
                goto out;
 
        ppc = (unsigned int)pr->performance_platform_limit;
-       if (!ppc)
-               goto out;
 
-       if (ppc > pr->performance->state_count)
+       if (ppc >= pr->performance->state_count)
                goto out;
 
        cpufreq_verify_within_limits(policy, 0,