]> err.no Git - linux-2.6/commitdiff
V4L/DVB (4995): Vivi: fix kthread_run() error check
authorAkinobu Mita <akinobu.mita@gmail.com>
Wed, 20 Dec 2006 13:04:00 +0000 (10:04 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 27 Dec 2006 16:20:12 +0000 (14:20 -0200)
The return value of kthread_run() should be checked by IS_ERR().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/vivi.c

index 3cead24a36c123fa3d9386c250d2b3d47f65a2f2..bacb311b4f24b6d6f645ac716d3ffc1be37902a3 100644 (file)
@@ -535,9 +535,9 @@ static int vivi_start_thread(struct vivi_dmaqueue  *dma_q)
 
        dma_q->kthread = kthread_run(vivi_thread, dma_q, "vivi");
 
-       if (dma_q->kthread == NULL) {
+       if (IS_ERR(dma_q->kthread)) {
                printk(KERN_ERR "vivi: kernel_thread() failed\n");
-               return -EINVAL;
+               return PTR_ERR(dma_q->kthread);
        }
        dprintk(1,"returning from %s\n",__FUNCTION__);
        return 0;