]> err.no Git - linux-2.6/commitdiff
[PATCH] ioremap balanced with iounmap for drivers/video/retz3fb
authorAmol Lad <amol@verismonetworks.com>
Fri, 8 Dec 2006 10:40:06 +0000 (02:40 -0800)
committerLinus Torvalds <torvalds@woody.osdl.org>
Fri, 8 Dec 2006 16:29:04 +0000 (08:29 -0800)
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/video/retz3fb.c

index cf41ff177644c3d9ecdb843a2f1790f5d73fb314..bc7ffc84e1855cf0276b1a6e0470a26cf8abb184 100644 (file)
@@ -1423,8 +1423,10 @@ int __init retz3fb_init(void)
 
                do_install_cmap(0, fb_info);
 
-               if (register_framebuffer(fb_info) < 0)
+               if (register_framebuffer(fb_info) < 0) {
+                       iounmap(zinfo->base);
                        return -EINVAL;
+               }
 
                printk(KERN_INFO "fb%d: %s frame buffer device, using %ldK of "
                       "video memory\n", fb_info->node,